Re: svn commit: r14898 - in trunk/subversion: tests/clients/cmdline

On 2005-06-02 17:20+0100, Philip Martin wrote:
> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>
> > On Wed, 1 Jun 2005, Philip Martin wrote:
> >
> >> lundblad@tigris.org writes:
> >
> >> > +
> >> > +
> >> > + svntest.actions.run_and_verify_svn(None, None, None, 'unlock',
> >> > + '--username', svntest.main.wc_author,
> >> > + '--password', svntest.main.wc_passwd,
> >> > + file_path)
> >>
> >> This doesn't verify that the lock got released.
> >>
> >>
> > But it verifies that there was no error output. Ain't that enough?
>
> Not really. A recent change caused 'svn unlock URL' to SEGV and the
> the test using it still passed. As it happens the SEGV occurred after
> the lock was removed, but if it had happened before the lock was
> removed the test would still have passed.

I will try to include and use subprocess[1] with our test framework
and see if it makes any difference with 'returncode'. This is new in
Python 2.4 and it won't probably help with win32, so coverage won't be
100%, but at least it might help a little.
 
BR, Jani

1) http://docs.python.org/lib/module-subprocess.html

-- 
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org