[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14898 - in trunk/subversion: tests/clients/cmdline

From: Brian W. Fitzpatrick <fitz_at_red-bean.com>
Date: 2005-06-02 18:14:37 CEST

On Jun 2, 2005, at 2:47 AM, Peter N. Lundblad wrote:

> On Wed, 1 Jun 2005, Philip Martin wrote:
>
>
>>> +
>>> +
>>> + svntest.actions.run_and_verify_svn(None, None, None, 'unlock',
>>> + '--username',
>>> svntest.main.wc_author,
>>> + '--password',
>>> svntest.main.wc_passwd,
>>> + file_path)
>>>
>>
>> This doesn't verify that the lock got released.
>>
>>
>>
> But it verifies that there was no error output. Ain't that
> enough? (BTW,
> looking at the break_lock test, that might have the same problem)?

I think that we need to rejigger all the locking tests to
run_and_verify status after locking/unlocking. We've already seen
several situations where svn segfaults and, since nothing showed up
on STDERR, the test succeeded.

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 2 18:29:11 2005

This is an archived mail posted to the Subversion Dev mailing list.