[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14918 - trunk/subversion/clients/cmdline

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-06-02 00:08:51 CEST

kfogel@collab.net writes:

>> > + SVN_ERR (svn_cl__try (svn_client_propset2 (pname_utf8, NULL, target,
>> > + opt_state->recursive,
>> > + FALSE, ctx, subpool),
>> > + &success, opt_state->quiet,
>> > + SVN_ERR_UNVERSIONED_RESOURCE,
>> > + SVN_ERR_ENTRY_NOT_FOUND,
>> > + NULL));
>> >
>> NULL? This is not a pointer, so I'd rather use 0 instead. Same in all
>> places.
>
> I thought about using 0 instead, but am so accustomed to NULL as a
> flag value in va lists that I went with that... However, if one person
> complained, then it should be changed, since my reasons for using NULL
> aren't particularly compelling :-).

How about SVN_NO_ERROR instead of 0?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 2 00:39:43 2005

This is an archived mail posted to the Subversion Dev mailing list.