[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14918 - trunk/subversion/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2005-06-01 21:51:38 CEST

"Peter N. Lundblad" <peter@famlundblad.se> writes:
> Maybe say that the errors must be 0-terminated, even if it is quite
> obvious.

Good idea.

> > +++ trunk/subversion/clients/cmdline/propdel-cmd.c Wed Jun 1 14:34:11 2005
> > @@ -117,10 +117,13 @@
> >
> > /* Pass FALSE for 'skip_checks' because it doesn't matter here,
> > and opt_state->force doesn't apply to this command anyway. */
> > - SVN_CL__TRY (svn_client_propset2 (pname_utf8, NULL, target,
> > - opt_state->recursive,
> > - FALSE, ctx, subpool),
> > - success, opt_state->quiet);
> > + SVN_ERR (svn_cl__try (svn_client_propset2 (pname_utf8, NULL, target,
> > + opt_state->recursive,
> > + FALSE, ctx, subpool),
> > + &success, opt_state->quiet,
> > + SVN_ERR_UNVERSIONED_RESOURCE,
> > + SVN_ERR_ENTRY_NOT_FOUND,
> > + NULL));
> >
> NULL? This is not a pointer, so I'd rather use 0 instead. Same in all
> places.

I thought about using 0 instead, but am so accustomed to NULL as a
flag value in va lists that I went with that... However, if one person
complained, then it should be changed, since my reasons for using NULL
aren't particularly compelling :-).

All done in r14919, thanks!

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 1 22:33:00 2005

This is an archived mail posted to the Subversion Dev mailing list.