[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2243 - 'svn add' command not keying off svn:ignore

From: S.Ramaswamy <ramaswamy_at_collab.net>
Date: 2005-05-11 18:07:03 CEST

> A quick review:
>
> S.Ramaswamy wrote:
>> Thanks for the review. Not sure where the new function should go -
>> libsvn_wc/status.c or elsewhere - I put it in status.c, since it has
>> similar functions. Revised patch:
>
> Seems a bit unlikely to me that it ought to be a new, fully public API.
> I'd have thought it should be local to the command-line client, but I
> haven't thought hard about it.
>
>> Fix issue #2243. Make 'svn add' honor svn:ignore property.
>>
>> * subversion/include/svn_wc.h
>> (svn_wc_get_ignores) : Added function prototype and doc string for
>> new function 'svn_wc_get_ignores'.
>>
>> * subversion/libsvn_wc/status.c
>> (svn_wc_get_ignores) : New function to return the default and
>> local
>> svn:ignore patterns.
>
> Didn't you mostly copy this from somewhere? If so, you should call it
> from there, rather than just duplicating it.

I think you are talking about svn_wc_get_default_ignores, a public method
for getting the ignore patterns from the ~/.subversion/config file. "svn
add" is using this function and not taking into account local per-directory
svn:ignore patterns. There was a thread earlier about a new function for
returning the default (config file) and local ignores - Hence the new
method. The new function is more like a convenience routine that calls
svn_wc_get_default_ignores and two lines from libsvn_wc/status.c to get the
list of all svn:ignore patterns.

Thanks
Ramaswamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 11 20:20:23 2005

This is an archived mail posted to the Subversion Dev mailing list.