[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2243 - 'svn add' command not keying off svn:ignore

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-05-11 16:50:19 CEST

A quick review:

S.Ramaswamy wrote:
> Thanks for the review. Not sure where the new function should go -
> libsvn_wc/status.c or elsewhere - I put it in status.c, since it has similar
> functions. Revised patch:

Seems a bit unlikely to me that it ought to be a new, fully public API. I'd
have thought it should be local to the command-line client, but I haven't
thought hard about it.

> Fix issue #2243. Make 'svn add' honor svn:ignore property.
>
> * subversion/include/svn_wc.h
> (svn_wc_get_ignores) : Added function prototype and doc string for
> new function 'svn_wc_get_ignores'.
>
> * subversion/libsvn_wc/status.c
> (svn_wc_get_ignores) : New function to return the default and local
> svn:ignore patterns.

Didn't you mostly copy this from somewhere? If so, you should call it from
there, rather than just duplicating it.

> Index: subversion/include/svn_wc.h
> ===================================================================
> --- subversion/include/svn_wc.h (revision 14685)
> +++ subversion/include/svn_wc.h (working copy)
> @@ -2930,6 +2930,15 @@
> apr_hash_t *config,
> apr_pool_t *pool);
>
> +/** Get the list of ignore patterns from the @c svn_config_t's in the
> + * @a config hash and the local ignore patterns from the directory
> + * in @adm_access. Allocate @a ignores and its contents in @pool.

No arg is named "ignores".

This needs "@since" if this is to be a fully public function like this.

> + */
> +svn_error_t *svn_wc_get_ignores (apr_array_header_t **patterns,
> + apr_hash_t *config,
> + svn_wc_adm_access_t *adm_access,
> + apr_pool_t *pool);

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 11 18:24:58 2005

This is an archived mail posted to the Subversion Dev mailing list.