[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2243 - 'svn add' command not keying off svn:ignore

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-05-11 20:51:51 CEST

S.Ramaswamy wrote:

>>A quick review:
>>
>>S.Ramaswamy wrote:
>>
>>
>>>Thanks for the review. Not sure where the new function should go -
>>>libsvn_wc/status.c or elsewhere - I put it in status.c, since it has
>>>similar functions. Revised patch:
>>>
>>>
>>Seems a bit unlikely to me that it ought to be a new, fully public API.
>> I'd have thought it should be local to the command-line client, but I
>>haven't thought hard about it.
>>
>>
>>
>>>Fix issue #2243. Make 'svn add' honor svn:ignore property.
>>>
>>>* subversion/include/svn_wc.h
>>> (svn_wc_get_ignores) : Added function prototype and doc string for
>>> new function 'svn_wc_get_ignores'.
>>>
>>>* subversion/libsvn_wc/status.c
>>> (svn_wc_get_ignores) : New function to return the default and
>>> local
>>> svn:ignore patterns.
>>>
>>>
>>Didn't you mostly copy this from somewhere? If so, you should call it
>>from there, rather than just duplicating it.
>>
>>
>
>I think you are talking about svn_wc_get_default_ignores, a public method
>for getting the ignore patterns from the ~/.subversion/config file.
>
No, I think he means the static function collect_ignore_patterns in
libsvn_wc/status.c. I mentioned that in an earlier post of mine, and I
said that we frown on code duplication.

collect_ignore_patterns is called exactly once in status.c, so that call
could be replaced with a call to svn_wc_get_ignores. On the other hand,
it might be better if svn_wc_get_ignores caleld collect_ignore_patterns.
I can't say offhand which option is more elegant, but you should
certainly do one or the other instead of copy-pasting the way you're
doing now.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 11 23:25:38 2005

This is an archived mail posted to the Subversion Dev mailing list.