[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14643 - in trunk/subversion: include libsvn_client libsvn_ra_dav libsvn_repos libsvn_wc

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-05-10 15:07:42 CEST

Julian Foad wrote:
> kfogel@collab.net wrote:
>> Greg Hudson <ghudson@MIT.EDU> writes:
>>> On Mon, 2005-05-09 at 01:07 -0500, kfogel@tigris.org wrote:
>>>> + if (pool == NULL)
>>>> + {
>>>> + pool = svn_pool_create (NULL);
>>>> + own_pool = TRUE;
>>>> + }
>>> A better way: create an internal function which accepts the buffer on
>>> the command line. Make the old API allocate the buffer on the stack,
>>> and the new one allocate it within the provided pool.
>> Presumably s/on the command line/as a parameter/.
>> But r14647 is an even better way IMHO, and it's now in STATUS.
> But r14647 removes all mention of argument "pool" from the API doc. Has
> it
> been voted through to branches/1.2.x already? Tut, tut :-)

There's nothing wrong with r14647. You can complain that there was no
documentation to begin with, perhaps, but that part of r14647 was a simple
reversion of the introduction of an unnecessarily complex coding style.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 10 15:08:39 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.