[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH 2] Allocating large buffers on the stack was: Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2005-05-08 16:52:27 CEST

> Max Bowsher wrote:
> > Patrick Mayweg wrote:
> >>> Hi,
> >>> this patch removes the last of the SVN_STREAM_CHUNK_SIZE buffers from
> >>> the stack and use the pool instead. This fixes the stack overflow for
> >>> the javahl binding on windows. I am not sure if this change is
> >>> permissible, because of the interface change.
> >
> > No, it is not, for exactly this reason.
>
> Although, the APIs in question are definitely going to be revved (as part
> of
> the keywords-as-hash changes) in 1.3, so
> keep your patch handy.

Well, I do see reasons to keep the API as stable as possible, but should we
do that at the cost of stacksize problems in applications which use our
api's?

bye,

Erik.

-- 
+++ Neu: Echte DSL-Flatrates von GMX - Surfen ohne Limits +++
Always online ab 4,99 Euro/Monat: http://www.gmx.net/de/go/dsl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 8 16:53:14 2005

This is an archived mail posted to the Subversion Dev mailing list.