Re: [PATCH 2] Allocating large buffers on the stack was: Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

Max Bowsher wrote:
> Patrick Mayweg wrote:
>>> Hi,
>>> this patch removes the last of the SVN_STREAM_CHUNK_SIZE buffers from
>>> the stack and use the pool instead. This fixes the stack overflow for
>>> the javahl binding on windows. I am not sure if this change is
>>> permissible, because of the interface change.
>
> No, it is not, for exactly this reason.

Although, the APIs in question are definitely going to be revved (as part of
the keywords-as-hash changes) in 1.3, so
keep your patch handy.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 8 16:40:11 2005