[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH 2] Allocating large buffers on the stack was: Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-08 18:20:47 CEST

On Sun, 8 May 2005, Erik Huelsmann wrote:

> > Max Bowsher wrote:
> > > Patrick Mayweg wrote:
> > >>> Hi,
> > >>> this patch removes the last of the SVN_STREAM_CHUNK_SIZE buffers from
> > >>> the stack and use the pool instead. This fixes the stack overflow for
> > >>> the javahl binding on windows. I am not sure if this change is
> > >>> permissible, because of the interface change.
> > >
> > > No, it is not, for exactly this reason.
> >
> > Although, the APIs in question are definitely going to be revved (as part
> > of
> > the keywords-as-hash changes) in 1.3, so
> > keep your patch handy.
>
> Well, I do see reasons to keep the API as stable as possible, but should we
> do that at the cost of stacksize problems in applications which use our
> api's?
>
No, we shouldn't. Not taking a pool is an API bug in nearly all cases I
can think of. Let's get these patches in before RC3! We need to whach out
which pools the callers pass, so we don't introduce memory leaks. I'll
look at the call sites later today.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 8 18:13:26 2005

This is an archived mail posted to the Subversion Dev mailing list.