[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14557 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_diff svnlook

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-05 20:54:02 CEST

On Wed, 4 May 2005, [UTF-8] Branko ─^Libej wrote:

> Philip Martin wrote:
>
> >lundblad@tigris.org writes:
> >
> >
> >
> >>Author: lundblad
> >>Date: Mon May 2 14:01:09 2005
> >>New Revision: 14557
> >>
> >>
> >
> >
> >
> >>--- trunk/subversion/libsvn_subr/cmdline.c (original)
> >>+++ trunk/subversion/libsvn_subr/cmdline.c Mon May 2 14:01:09 2005
> >>@@ -356,3 +356,11 @@
> >>
> >> return SVN_NO_ERROR;
> >> }
> >>+
> >>+const char *svn_cmdline_output_encoding (apr_pool_t *pool)
> >>+{
> >>+ if (output_encoding)
> >>+ return apr_pstrdup (pool, output_encoding);
> >>
> >>
> >
> >Why the apr_pstrdup?
> >
> >
> Yes, I just noticed this and asked myself the same thing. There's no
> need to copy this string around.
>
Because that's what the docstring says it does. So, why did he write the
docstring that way? Because I think it is consistent with what we do
elsewhere.

Well, we could change it, but is it a big deal, really?

Best,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 5 20:46:56 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.