[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14557 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_diff svnlook

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-05-06 18:28:04 CEST

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> On Wed, 4 May 2005, [UTF-8] Branko ^Libej wrote:
>
>> Philip Martin wrote:
>>
>> >Why the apr_pstrdup?
>> >
>> Yes, I just noticed this and asked myself the same thing. There's no
>> need to copy this string around.
>>
> Because that's what the docstring says it does. So, why did he write the
> docstring that way? Because I think it is consistent with what we do
> elsewhere.

I'm aware that input strings are sometimes duplicated before being
returned, but that's to avoid making assumptions about the lifetime of
the inputs. That consideration doesn't apply in this case, so the
consistency argument doesn't seem to apply.

> Well, we could change it, but is it a big deal, really?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 6 18:36:51 2005

This is an archived mail posted to the Subversion Dev mailing list.