[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14557 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_diff svnlook

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-05-04 23:24:15 CEST

Philip Martin wrote:

>lundblad@tigris.org writes:
>
>
>
>>Author: lundblad
>>Date: Mon May 2 14:01:09 2005
>>New Revision: 14557
>>
>>
>
>
>
>>--- trunk/subversion/libsvn_subr/cmdline.c (original)
>>+++ trunk/subversion/libsvn_subr/cmdline.c Mon May 2 14:01:09 2005
>>@@ -356,3 +356,11 @@
>>
>> return SVN_NO_ERROR;
>> }
>>+
>>+const char *svn_cmdline_output_encoding (apr_pool_t *pool)
>>+{
>>+ if (output_encoding)
>>+ return apr_pstrdup (pool, output_encoding);
>>
>>
>
>Why the apr_pstrdup?
>
>
Yes, I just noticed this and asked myself the same thing. There's no
need to copy this string around.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 4 23:24:58 2005

This is an archived mail posted to the Subversion Dev mailing list.