[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14478 - in trunk/subversion: tests/libsvn_subr

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-04-28 19:06:49 CEST

"Peter N. Lundblad" <peter@famlundblad.se> writes:

>> {
>> apr_size_t j;
>>
>> - assert (path);
>> + for(j = 0; path[j]; ++j)
>
> Missing space before paren.

OK.

>> + if (path[j] == ':' || path[j] == '/')
>> + break;
>>
> Please put multiline statements in braces.

I don't think that is an improvement.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 28 19:56:21 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.