[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Include offending XML in "Malformed XML" error message

From: Charles Bailey <bailey.charles_at_gmail.com>
Date: 2005-04-27 23:13:13 CEST

On 4/27/05, Julian Foad <julianfoad@btopenworld.com> wrote:
> Charles Bailey wrote:
> > Comments welcomed, before I invest any more time along this path.
>
> Uh, no really useful comments from me, just a simple bug: your example program
> says "255" a lot where you mean "256" at least in some places like here:
>
> > svn_escape_utf8 (svn_stringbuf_t **outsbuf,
> [...]
> > static unsigned char utf8safe[255];
> [...]
> > memset (utf8safe + 0xf5, 255, 11); /* oxf5 - 0xff always illegal */
>
> This "memset" overruns the array.

Urk. Dumb been-up-too-long thinko. Thanks.

-- 
Regards,
Charles Bailey
Lists: bailey _dot_ charles _at_ gmail _dot_ com
Other: bailey _at_ newman _dot_ upenn _dot_ edu
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 27 23:15:45 2005

This is an archived mail posted to the Subversion Dev mailing list.