Re: [PATCH] - Mistake in 1.2 Release Notes - correction

Mark Phippard wrote:
> Julian Foad <julianfoad@btopenworld.com> wrote on 04/06/2005 04:18:21 PM:
>
>> Mark Phippard wrote:
>>> [[[
>>> Correct new command line switch for svnlook diff.
>>
>> It's not the command-line switch that you're correcting, but the
> references to
>> it in the release notes. I'd suggest as a log message summary something
> like:
>>
>> Correction to the release notes.
>
> OK. I will commit with a message along those lines.

Julian didn't actually say "approved" or "+1", so technically you shouldn't
really have committed this yet.

On the other hand, thanks for sorting out the patch, and to clear things up,
I'll retro-actively say "+1" to this change.

Just check to see if a committer's message is a comment or an approval a
little more carefully in future.

(And always include "Approved by: <username>" in log messages of approved
commits).

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 7 01:32:19 2005