Re: missing error checking in svn_config__parse_file

Ph. Marek wrote:

>On Monday 04 April 2005 11:47, Peter N. Lundblad wrote:
>
>
>>This leaks the open file. also note that whenever err is set, ch gets set
>>to EOF, so the loop will terminate in that case. So, you don't need this
>>fix.
>>
>>
>No, it doesn't.
>
Do tell. Yes it does, it's just not as obvious as you seem to think it
should be.

>And from my feeling, the test should be for
> err != SVN_NO_ERROR,
>
>
Nope, see HACKING. We never compar to SVN_NO_ERROR.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 22:23:04 2005