Kobayashi Noritada wrote:
> Hi,
>
> In testing revision HEAD, I got a following FS module list by running
> 'svn{,admin,look,serve} --version':
>
> The following repository back-end (FS) modules are available:
>
> * fs_base : ^Cq^B
> * fs_fs : Module for working with a plain file (FSFS) repository.
>
> I do not have the bdb backend installed, but it occurs on the list and its
> description get strange.
> To fix this, I made a following patch.
>
> Thanks,
>
> - nori
>
>
> Log:
> Fix a bug in getting FS module list, which should not contain items for
> unloadable filesystems.
>
> * subversion/libsvn_fs/fs-loader.c
> (svn_fs_print_modules): Make FS module list contain a filesystem only
> if it is loadable.
>
>
> Index: subversion/libsvn_fs/fs-loader.c
> ===================================================================
> --- subversion/libsvn_fs/fs-loader.c (revision 13780)
> +++ subversion/libsvn_fs/fs-loader.c (working copy)
> @@ -931,10 +931,13 @@
> return err;
> }
>
> - line = apr_psprintf (iterpool, "* fs_%s : %s\n",
> - defn->fsap_name,
> - vtable->get_description());
> - svn_stringbuf_appendcstr (output, line);
> + if (defn->initfunc != NULL)
> + {
> + line = apr_psprintf (iterpool, "* fs_%s : %s\n",
> + defn->fsap_name,
> + vtable->get_description());
> + svn_stringbuf_appendcstr (output, line);
> + }
> }
>
> svn_pool_destroy (iterpool);
The patch is incorrect.
As I warned in the r13761 log message:
***** FS module vtable change. If an old 1.2.0-dev build of libsvn_fs_base
***** is picked up by a new 1.2.0-dev build of libsvn_fs, nasty stuff will
***** happen - probably segfaults.
I think nasty stuff is happening because you have a stale version of
libsvn_fs_base somewhere.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 31 12:42:59 2005