[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Correct error in printing FS module list

From: Kobayashi Noritada <nori1_at_dolphin.c.u-tokyo.ac.jp>
Date: 2005-03-31 06:27:16 CEST

Hi,

In testing revision HEAD, I got a following FS module list by running
'svn{,admin,look,serve} --version':

  The following repository back-end (FS) modules are available:
  
  * fs_base : ^Cq^B
  * fs_fs : Module for working with a plain file (FSFS) repository.

I do not have the bdb backend installed, but it occurs on the list and its
description get strange.
To fix this, I made a following patch.

Thanks,

- nori

Log:
Fix a bug in getting FS module list, which should not contain items for
unloadable filesystems.

* subversion/libsvn_fs/fs-loader.c
  (svn_fs_print_modules): Make FS module list contain a filesystem only
    if it is loadable.

Index: subversion/libsvn_fs/fs-loader.c
===================================================================
--- subversion/libsvn_fs/fs-loader.c (revision 13780)
+++ subversion/libsvn_fs/fs-loader.c (working copy)
@@ -931,10 +931,13 @@
             return err;
         }
 
- line = apr_psprintf (iterpool, "* fs_%s : %s\n",
- defn->fsap_name,
- vtable->get_description());
- svn_stringbuf_appendcstr (output, line);
+ if (defn->initfunc != NULL)
+ {
+ line = apr_psprintf (iterpool, "* fs_%s : %s\n",
+ defn->fsap_name,
+ vtable->get_description());
+ svn_stringbuf_appendcstr (output, line);
+ }
     }
 
   svn_pool_destroy (iterpool);

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 31 06:28:28 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.