[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: [PATCH] #2246: repos_get_commit_editor API

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-03-28 19:15:27 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> clkao meant to send this to the whole list:
> Begin forwarded message:
> > From: Chia-liang Kao <clkao@clkao.org>
> > Date: March 28, 2005 10:20:56 AM CST
> > To: Ben Collins-Sussman <sussman@collab.net>
> > Subject: Re: [PATCH] #2246: repos_get_commit_editor API
> >
> > On Mon, Mar 28, 2005 at 09:07:02AM -0600, Ben Collins-Sussman wrote:
> >> How about a different approach: why not just 'rev' the existing API?
> >> Create svn_repos_get_commit_editor2(), and have it take an optional
> >> pre-existing txn parameter? If the new parameter is NULL, then
> >> open_root() will create a new txn. If the new parameter is non-NULL,
> >> then open_root() will do nothing.
> >
> > Ya I thought about that too but thought people might not like it for
> > multitude of **txn that can be null to indicate we want a new txn.
> > and the thing that we want a immediately usable txn (obtained by the
> > new api) is that we can do txn->change_txn_prop for doing all the
> > fine things tweaking rev-props as atomic operations.

Hrm. Given the choice between propogating another NULL argument up
to, what, a handful of callers, versus maintaining a new, separate API
that's not even used *at all* by Subversion itself ... well, I'll take
what's behind Door #1, Alex.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 28 19:19:48 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.