John Szakmeister wrote:
> I'm a little confused... why would it be inconsistent to have them both be
> whitespace separated? Or at least follow the way auto-props are done
> with files? *shrug*
AFAIK svn:ignore needs to be *newline* seperated. If we allow whitespace in the
config file noone will be sure what works and what is needed where.
> > * = *.o\n*.lo\n*.la\n*~\n
> Yeah, that's ugly.
> > * = *.o\n
> > *.lo\n
> > *.la\n
> > *~\n
> Eh. I'm not necessarily a fan of that either.
I think that too.
But on the other side:
> > The other possibility would be to concatenate multiple matching lines
> > with an \n in between:
> > [dir-auto-props]
> > * = *.o
> > *.tmp = *.tmp
> > * = *.la
> > * = *.lo
I believe that would be much worse in the future. (But that's just a feeling -
if everybody else tells me it's ok and we'll love the newline-concatenated
lines for ever after I'll buy that, too)
I just fear that this will bite us sometime.
At least if there are other properties (bad example, like svn:commit-time) who
never should have a newline - if somebody just inserts a line in his config
file (because he didn't see the one already existing) he gets newlines in
properties - and that may cause bad problems (just remember issue 1401 which
bit me hard [http://subversion.tigris.org/issues/show_bug.cgi?id=1401]).
So:
> > I believe that we should require explicit \n (or whatever) and not just
> > concatenate the property values.
> > If noone tells me otherwise I'd propose to use that (and try to make a
> > patch for that).
> > But:
> > Do we need unicode characters encoded? Are unicode-characters in
> > filenames common? How should they be encoded with a \x??-syntax? Do we
> > want to have them UTF8-encoded in the config-files?
>
> Good question. I believe everything is expected to be UTF-8 in the config
> file, but I haven't confirmed that at all.
I have some alternatives:
a) use C-style \\, \x??, \n, \r
b) use HTML-style &, �d; etc.
c) use URI-style %0d, %0a, etc.
I'd vote for a).
Possibly we could allow \{????????} for unicode characters.
Max wanted to have some encoding in both values and keys:
> Basically, we need to redefine our config parser format.
>
> I've already run into problems with it regarding usernames containing
> certain characters in authz_svn files.
>
> Someone want to start working out a way to allow config keys and values to
> contain arbitrary characters, whilst disrupting the old config format as
> little as possible?
but that would be the least problem.
Opinions? Other wishes?
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 26 20:08:25 2005