[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FSFS vtable doesn't initialise parse_id

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-03-26 20:01:25 CET

Greg Hudson <ghudson@MIT.EDU> writes:

> On Sat, 2005-03-26 at 13:41, Philip Martin wrote:
>> It's static so it will be null, which means calling svn_fs_parse_id on
>> an FSFS repository will SEGV.
>
> You don't call svn_fs_parse_id on a repository. That's the whole
> problem. You just call it with an ID. It always tries to use the BDB
> implementation.

Looking closer I see that now.

> Fixing the warning by adding an explicit NULL would be fine.

I don't think I'll bother, it's just one amongst dozens of "missing
initializer" warnings, if I'd spent a bit more time looking at
svn_fs_parse_id I would not even have asked the question.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 26 20:02:39 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.