[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Locking branch has been merged [Re: svn commit: r13571]

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-03-22 23:58:17 CET

On Mar 22, 2005, at 3:12 PM, Philip Martin wrote:

> Ben Collins-Sussman <sussman@collab.net> writes:
>> After four months of work, the locking branch is merged and gone.
>> Huge thanks to Fitz and Lundblad, you guys were amazing. And thanks
>> to Sander for helping with the libsvn_fs_base schema, and cmpilato and
>> kfogel for undying support... and ... um... I'd like to thank the
>> Academy...
>> So start playing around. Find the bugs. I'd like to branch for 1.2
>> in a week. :-)
> I see that you changed the svn_wc_entry_t struture:
> - It is now about 20% bigger on a typical 32-bit machine. The entries
> caching in the client means that there are lots of these in memory,
> I don't know what proportion of the memory they use but it's
> possible it will noticeably affect the memory used by the client.

We've added three (const char *) fields and one apr_time_t to the entry

If we assume that most files will be unlocked most of the time, then
those four new fields will almost always be NULL. This will still be a
20% memory increase?

> - I have a nasty feeling that it qualifies as an ABI change

It does? I thought it was safe to add fields to the end of a structure.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 22 23:59:40 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.