Re: Locking branch has been merged [Re: svn commit: r13571]

Ben Collins-Sussman <sussman@collab.net> writes:

> After four months of work, the locking branch is merged and gone.
>
> Huge thanks to Fitz and Lundblad, you guys were amazing. And thanks
> to Sander for helping with the libsvn_fs_base schema, and cmpilato and
> kfogel for undying support... and ... um... I'd like to thank the
> Academy...
>
> So start playing around. Find the bugs. I'd like to branch for 1.2
> in a week. :-)

I see that you changed the svn_wc_entry_t struture:

- It is now about 20% bigger on a typical 32-bit machine. The entries
  caching in the client means that there are lots of these in memory,
  I don't know what proportion of the memory they use but it's
  possible it will noticeably affect the memory used by the client.

- I have a nasty feeling that it qualifies as an ABI change, so the
  rules require a new svn_wc_entry2_t. Yuck! I really don't like the
  size of the changes we would need to accomodate that.

Perhaps the lock data could be stored in a separate cache within the
access baton, then no change to svn_wc_entry_t would be required.
A separate cache could avoid using any significant memory if there are
no locks.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org