Re: [PATCH] with log Re: svn_auth_cred_simple_t crash

Martin Hauner wrote:
> Greg Hudson wrote:
>> We're unlikely to accept this patch. We recently decided that if we
>> document "the pointer must not be NULL" in one place, we are compelled
>> to document that everywhere (as people who read the restriction in one
>> place might begin to assume that the restriction only applies when
>> explicitly mentioned), and that's too wordy.
>
> I general i agree, but in this case i would prefer a note.

What we need, is a more obvious place to document things which are common
across our whole API.

The "NULL not allowed unless explicitly stated" rule is common knowledge
amongst those who actually hack on Subversion a lot, but I think the only
place it is documented right now is in HACKING, which isn't exactly API
docs.

On the other hand, passing NULL to something when you haven't been told it
is explicitly allowed is kind of tempting fate.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 17 00:16:46 2005