Re: [PATCH] with log Re: svn_auth_cred_simple_t crash

Greg Hudson wrote:
> We're unlikely to accept this patch. We recently decided that if we
> document "the pointer must not be NULL" in one place, we are compelled
> to document that everywhere (as people who read the restriction in one
> place might begin to assume that the restriction only applies when
> explicitly mentioned), and that's too wordy.

I general i agree, but in this case i would prefer a note.

> I don't know where you got the idea that passwords are "kind of
> optional". We have a separate auth provider for just the username.

Because I can't know in advance if the user will enter a password or not.

Anyway, I'll stop here..

I have already fixed the problem on my side and maybe other users of
svn_auth_cred_simple_t are smarter than me and and don't fall over
this one. ;-)

-- 
Martin
Subcommander, http://subcommander.tigris.org
a x-platform Win32/Unix svn gui (qt) client & a text diff/merge tool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org