[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Locking] svnadmin prints out newline unconditionally.

From: Brian W. Fitzpatrick <fitz_at_red-bean.com>
Date: 2005-03-16 15:21:28 CET

Is there a reason that it does this? I've attached a patch that
removes it, but wanted to run it past someone else (sussman? lundblad?)
to see if there was a deep dark reason that we always wanted an empty
line at the beginning of lslock's output. Patch to fix attached (I'll
commit it if no one objects).

-Fitz

[[
Remove spurious newline in svnadmin lslocks command

* subversion/svnadmin/main.c: Zap printf.
]]

Index: subversion/svnadmin/main.c
===================================================================
--- subversion/svnadmin/main.c (revision 13426)
+++ subversion/svnadmin/main.c (working copy)
@@ -996,8 +996,6 @@
    /* Fetch all locks on or below the root directory. */
    SVN_ERR (svn_repos_fs_get_locks (&locks, repos, "/", NULL, NULL,
pool));

- SVN_ERR (svn_cmdline_printf (pool, "\n"));
-
    for (hi = apr_hash_first (pool, locks); hi; hi = apr_hash_next (hi))
      {
        const void *key;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 16 15:25:27 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.