Re: svn commit: r13351 - in branches/meta-data-versioning: . owner-group-mode owner-group-mode/subversion/libsvn_client owner-group-mode/subversion/libsvn_subr owner-group-mode/subversion/libsvn_wc

pmarek@tigris.org writes:

> Author: pmarek
> Date: Thu Mar 10 07:03:23 2005
> New Revision: 13351
 
> --- branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c (original)
> +++ branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c Thu Mar 10 07:03:23 2005
> @@ -2837,7 +2837,6 @@
> apr_uid_t uid;
> apr_finfo_t finfo;
> apr_fileperms_t perms;
> - char *errorptr;
>
> /* this function should move to apr */
> #ifdef _WIN32
> @@ -2846,11 +2845,11 @@
> if (owner || group)
> {
> if (owner && owner->data)
> - if (svn_io_file_owner_id(&uid, owner, pool) != SVN_NO_ERROR)
> + if (svn_io_file_owner_id(&uid, (svn_string_t*)owner, pool) != SVN_NO_ERROR)

Something is wrong, in new code you should not have to cast away const
like that, better to change the interface.

> uid=-1;
>
> if (group && group)
> - if (svn_io_file_group_id(&gid, group, pool) != SVN_NO_ERROR)
> + if (svn_io_file_group_id(&gid, (svn_string_t*)group, pool) != SVN_NO_ERROR)
> gid=-1;
>
> if (uid != -1 && gid != -1)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org