pmarek@tigris.org writes:
> Log:
> r164@inet: flip | 2005-03-10 13:49:15 +0100
>
> * subversion/libsvn_client/export.c
> * subversion/libsvn_subr/io.c
> * subversion/libsvn_wc/adm_ops.c
> Compile-time-fixes from forward-porting.
This log message does not explain the change at all. Looking at the
diff, you did many things, none of which can be understood without a
real log message.
Conformant log messages are not optional. If these changes are going
into our repository, even on a branch, they need to be understandable
and reviewable by everyone. I had thought this was always clear (?),
sorry if it wasn't.
(If you are merging a change from one branch to another, within this
repository, then you do not need to repeat the log message. Instead,
you can just say "Merged rXXXXX from branches/text-time." or
whatever. But that does not appear to be what's happening here.)
Can you please follow the log message guidelines in HACKING?
It's fine to include these change identifiers from your other
repository (I'm assuming that's what they are):
r164@inet: flip | 2005-03-10 13:49:15 +0100
But don't put them in the most prominent place in the log message!
Put a real summary of the change there. These identifiers are just
metadata tags. Put them near the end, clearly marked off as metadata,
so they don't distract someone trying to understand the change.
Thanks,
-Karl
> Modified: branches/meta-data-versioning/owner-group-mode/subversion/libsvn_client/export.c
> Url: http://svn.collab.net/viewcvs/svn/branches/meta-data-versioning/owner-group-mode/subversion/libsvn_client/export.c?view=diff&rev=13351&p1=branches/meta-data-versioning/owner-group-mode/subversion/libsvn_client/export.c&r1=13350&p2=branches/meta-data-versioning/owner-group-mode/subversion/libsvn_client/export.c&r2=13351
> ==============================================================================
> --- branches/meta-data-versioning/owner-group-mode/subversion/libsvn_client/export.c (original)
> +++ branches/meta-data-versioning/owner-group-mode/subversion/libsvn_client/export.c Thu Mar 10 07:03:23 2005
> @@ -177,7 +177,7 @@
> tm = entry->cmt_date;
>
> if (text_time)
> - SVN_ERR(svn_time_from_cstring (&tm, text_time->data, iterpool));
> + SVN_ERR(svn_time_from_cstring (&tm, text_time->data, pool));
> }
>
> if (keywords)
> @@ -216,13 +216,13 @@
>
> if (! special)
> {
> - SVN_ERR (svn_io_set_file_affected_time (tm, copy_to, iterpool));
> + SVN_ERR (svn_io_set_file_affected_time (tm, to, pool));
>
> - SVN_ERR (svn_io_file_set_file_owner_group_mode (copy_to,
> + SVN_ERR (svn_io_file_set_file_owner_group_mode (to,
> owner,
> group,
> mode,
> - iterpool) );
> + pool) );
> }
>
> return SVN_NO_ERROR;
>
> Modified: branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c
> Url: http://svn.collab.net/viewcvs/svn/branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c?view=diff&rev=13351&p1=branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c&r1=13350&p2=branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c&r2=13351
> ==============================================================================
> --- branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c (original)
> +++ branches/meta-data-versioning/owner-group-mode/subversion/libsvn_subr/io.c Thu Mar 10 07:03:23 2005
> @@ -2837,7 +2837,6 @@
> apr_uid_t uid;
> apr_finfo_t finfo;
> apr_fileperms_t perms;
> - char *errorptr;
>
> /* this function should move to apr */
> #ifdef _WIN32
> @@ -2846,11 +2845,11 @@
> if (owner || group)
> {
> if (owner && owner->data)
> - if (svn_io_file_owner_id(&uid, owner, pool) != SVN_NO_ERROR)
> + if (svn_io_file_owner_id(&uid, (svn_string_t*)owner, pool) != SVN_NO_ERROR)
> uid=-1;
>
> if (group && group)
> - if (svn_io_file_group_id(&gid, group, pool) != SVN_NO_ERROR)
> + if (svn_io_file_group_id(&gid, (svn_string_t*)group, pool) != SVN_NO_ERROR)
> gid=-1;
>
> if (uid != -1 && gid != -1)
>
> Modified: branches/meta-data-versioning/owner-group-mode/subversion/libsvn_wc/adm_ops.c
> Url: http://svn.collab.net/viewcvs/svn/branches/meta-data-versioning/owner-group-mode/subversion/libsvn_wc/adm_ops.c?view=diff&rev=13351&p1=branches/meta-data-versioning/owner-group-mode/subversion/libsvn_wc/adm_ops.c&r1=13350&p2=branches/meta-data-versioning/owner-group-mode/subversion/libsvn_wc/adm_ops.c&r2=13351
> ==============================================================================
> --- branches/meta-data-versioning/owner-group-mode/subversion/libsvn_wc/adm_ops.c (original)
> +++ branches/meta-data-versioning/owner-group-mode/subversion/libsvn_wc/adm_ops.c Thu Mar 10 07:03:23 2005
> @@ -40,6 +40,7 @@
> #include "svn_io.h"
> #include "svn_md5.h"
> #include "svn_xml.h"
> +#include "svn_time.h"
>
> #include "wc.h"
> #include "log.h"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 10 20:28:46 2005