On Tue, 2005-03-08 at 17:48, John Peacock wrote:
> Overall, very nice. I like how you made sure that you cannot set the same
> keyword twice (but you should really add a test for that just to show that it
> works).
There is a test for this... anyways, we shall continue on the other
thread. thanks for the input.
> It's also nicer if you include the commit message in your e-mail (i.e.
> before any attachments), just so people can see up front what they are going to
> review. My personal preference is for the order of files in the commit message
> to match up with the order of the files in the diff file (but that's just me).
You have a point there. But I'm finding it difficult to put my comments/
acknowledgements if I put the log message in the mail. :-( . Do you have
any suggestions? pl. let me know.
Thanks,
Madan.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 8 15:02:06 2005