[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Issue #2219 - svn:keywords canonicalization - code, test fix

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-03-08 15:08:14 CET

On Tue, 2005-03-08 at 17:48, John Peacock wrote:
> Overall, very nice. I like how you made sure that you cannot set the same
> keyword twice (but you should really add a test for that just to show that it
> works).
There is a test for this... anyways, we shall continue on the other
thread. thanks for the input.
> It's also nicer if you include the commit message in your e-mail (i.e.
> before any attachments), just so people can see up front what they are going to
> review. My personal preference is for the order of files in the commit message
> to match up with the order of the files in the diff file (but that's just me).
You have a point there. But I'm finding it difficult to put my comments/
acknowledgements if I put the log message in the mail. :-( . Do you have
any suggestions? pl. let me know.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 8 15:02:06 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.