Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords

Madan U Sreenivasan wrote:
> Hi,
> Pl. find code fix and tests for issue #2219 attached.

Sorry, I didn't see this before I commented on the other. I see you added the
include file, but I would still suggest putting the typedef, etc. there as well
(since it is essentially part of the public interface now). Of course, I would
rather see all of the code from subst.c moved to props.c as a private function,
but we need to have that argument first.

...
> + /* If so, canonicalize and prepare output */
> + if (!canonicalized_value)
> + canonicalized_value = svn_stringbuf_create (
> + canon_table_for_keywords[canon_table_for_keywords[j].
> + index].prop_value,
> + pool);

That code is still indented strangely (but it's so long, I don't know how much
more can be done). Perhaps the variable names are simply too long?
canon_keywords is probably sufficient as a variable name.

> + else
> + {
> + svn_stringbuf_appendcstr (
> + canonicalized_value,
> + " ");

still has odd indenting

> + svn_stringbuf_appendcstr (
> + canonicalized_value,
> + canon_table_for_keywords[canon_table_for_keywords[j].
> + index].prop_value);
...

still has odd indenting

HTH

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org