On Mon, 7 Mar 2005, Ben Collins-Sussman wrote:
>
> On Mar 5, 2005, at 4:27 PM, Peter N. Lundblad wrote:
>
> > So the path is allowed to be null in an svn_lock_t?
> >
>
> Hm, no, it shouldn't be. A lock_t's path field should always be an
> absolute fs path, on either side of the network.
>
> But there's no easy way to do fill it in within libsvn_client/info.c.
> Not without calling svn_ra_get_repos_root on every single
> svn_wc_entry_t->URL and then subtracting it! It would be horribly
> inefficient.
>
> Perhaps the real question is: why isn't it being stored as an
> entryprop, along with {token, owner, comment, creationdate}? And why
> isn't expirationdate in there as well?
>
The latter question was discussed before Christmas if I remember
correctly. Why would you put in an expiration date in the WC. It can never
appear there as long as we dont a) import locks into WCs from the server
or b) support expiration dates in our client UI (except for showing it
when viewing locks that are in the repository.)
For the former question, I think it would be very ugly to store the
absolute path as a lock entryprop. It would also be redundant. We have
some features that depend on the repository root URL being available in
the entries file. That's issue #960. If someone solves that issue once and
for all, we're done.
I think the short term solution is to document that the path will be NULL
in this particular case. The info cmdline code doesn't need the full path
anyway. I just wanted to point that out in a somewhat subtle way:-)
regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 7 22:26:32 2005