On Mar 5, 2005, at 4:27 PM, Peter N. Lundblad wrote:
> On Fri, 4 Mar 2005 sussman@tigris.org wrote:
>> Modified: branches/locking/subversion/libsvn_client/info.c
>> Url:
>> http://svn.collab.net/viewcvs/svn/branches/locking/subversion/
>> libsvn_client/info.c?view=diff&rev=13264&p1=branches/locking/
>> subversion/libsvn_client/info.c&r1=13263&p2=branches/locking/
>> subversion/libsvn_client/info.c&r2=13264
>> ======================================================================
>> ========
>> --- branches/locking/subversion/libsvn_client/info.c (original)
>> +++ branches/locking/subversion/libsvn_client/info.c Fri Mar 4
>> 13:22:17 2005
>> @@ -86,6 +89,17 @@
>> tmpinfo->conflict_wrk = entry->conflict_wrk;
>> tmpinfo->prejfile = entry->prejfile;
>>
>> + /* lock stuff */
>> + if (entry->lock_token) /* the token is the critical bit. */
>> + {
>> + tmpinfo->lock = apr_pcalloc (pool, sizeof(*(tmpinfo->lock)));
>> +
>> + tmpinfo->lock->token = entry->lock_token;
>> + tmpinfo->lock->owner = entry->lock_owner;
>> + tmpinfo->lock->comment = entry->lock_comment;
>> + tmpinfo->lock->creation_date = entry->lock_crt_date;
>
> So the path is allowed to be null in an svn_lock_t?
>
Hm, no, it shouldn't be. A lock_t's path field should always be an
absolute fs path, on either side of the network.
But there's no easy way to do fill it in within libsvn_client/info.c.
Not without calling svn_ra_get_repos_root on every single
svn_wc_entry_t->URL and then subtracting it! It would be horribly
inefficient.
Perhaps the real question is: why isn't it being stored as an
entryprop, along with {token, owner, comment, creationdate}? And why
isn't expirationdate in there as well?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 7 18:19:00 2005