[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Attn: fitz - Re: svn commit: r13266 - branches/locking/subversion/libsvn_client

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-03-05 20:39:56 CET

Branko Čibej wrote:
> Max Bowsher wrote:
>> fitz@tigris.org wrote:
>>> Author: fitz
>>> Date: Fri Mar 4 17:10:40 2005
>>> New Revision: 13266
>>> Modified:
>>> branches/locking/subversion/libsvn_client/locking_commands.c
>>> Log:
>>> Fix stupid crasher bug (committed by me) when attempting to lock files
>>> that are in subdirectories.
>>> * /trunk/subversion/subversion/libsvn_client/locking_commands.c
>>> (open_lock_targets): Index into the same array that you're iterating
>>> over. Duh.
>> Hi.
>> In several recent commits you've been using a weird form of filename
>> in log messages.
>> In this case, it is particularly incorrect, since it says "trunk" but
>> was actually a branch commit.
> This is getting worse and worse. Soon we'll be so far along that not a
> single commit will be made with a well-formed log message.
> We've relied on self-discipline to keep the format consistent for years
> now, but it seems that some of the new (and old!) committers are
> slipping their leash. So. Is it time to write that hook that rejects
> commits with log messages that don't conform to the documented format?

I don't think our format is sufficiently rigorously defined for that to be

I think that the problem is still sufficiently small that self-discipline
combined with pointing out of mistakes can continue to work.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 5 20:41:23 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.