[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Attn: fitz - Re: svn commit: r13266 - branches/locking/subversion/libsvn_client

From: <kfogel_at_collab.net>
Date: 2005-03-05 20:17:51 CET

Branko Čibej <brane@xbc.nu> writes:
> This is getting worse and worse. Soon we'll be so far along that not a
> single commit will be made with a well-formed log message.

I don't think it's getting worse and worse. It's just that two things
happened at the same time, by random coincidence:

   1. We added a unusual number of branch committers and partial
      committers in the same week, and they're still learning the
      ropes. This is normal, it happens every time we add new people,
      the only difference here is that it's three or four people
      instead of one. This will iron itself out naturally; we have
      already seen the 'propchange' emails start to come in as they
      correct recent log messages.

   2. Fitz started committing with some weird paths. I suspect this
      is due to some bug in the Emacs code and/or macros that (IIRC)
      he uses to help produce the paths in his log messages, and does
      not reflect any intentional drift away from the standards. As
      in case (1), Fitz can just fix up the old log messages and make
      sure future ones are okay.

In short, there is no crisis here. There's merely a temporarily high
tide of log message problems, which we have detected, and which can
all be corrected by the usual means.

> We've relied on self-discipline to keep the format consistent for
> years now, but it seems that some of the new (and old!) committers are
> slipping their leash. So. Is it time to write that hook that rejects
> commits with log messages that don't conform to the documented format?

For the reasons given above, I think a hook is not necessary.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 5 20:37:29 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.