[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Notification API

From: <kfogel_at_collab.net>
Date: 2005-03-02 16:34:35 CET

"Peter N. Lundblad" <peter@famlundblad.se> writes:
> > > Also, svn_client_ctx_t is extensible by design. It is possible
> > > to add the new notify function/baton as new
> > > fields. svn_client_create_context could init them to a
> > > function/baton that forwards to the old function. The other
> > > alternative is to revise svn_client_ctx_t, leading to revision
> > > of all client functions. Which do you prefer as the least ugly
> > > way? Or do I miss an obvious other alternative?
> I still want an opinion about the above paragraph.

So the idea is to put

          svn_wc_notify_func_t2 notify_func2;
          void *notify_baton2;

at the end of svn_client_ctx_t? But I'm unclear on exactly how
svn_client_create_context is supposed forward after that. That
function doesn't have a handle on the actual notify_func and baton the
caller is going to put in the ctx, so how can it set up the call
forwarding? All svn_client_create_context does is allocate the
structure; it doesn't currently initialize any fields.

I guess I'm not sure exactly what you're proposing. Could you
describe it in more detail, or in patch form?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 2 17:02:38 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.