[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 2154 - svn blame on a directory over DAV does not return gracefully

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2005-02-28 18:01:51 CET

VK Sameer wrote:

> Checking for !derr first would let 'goto cleanup:' be retained in
> file_revs.c, but I don't know if that is a reasonable solution in all
> cases. version.c doesn't use the goto idiom, so it doesn't seem to need
> this fix. Comments?

I believe that checking for !derr first is reasonable as the flush is only
an optimization anyway. So, if we got an error that we're going to
return, then it isn't critical for us to flush as its not likely we wrote
anything at that point. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 28 18:03:53 2005

This is an archived mail posted to the Subversion Dev mailing list.