[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 2154 - svn blame on a directory over DAV does not return gracefully

From: <kfogel_at_collab.net>
Date: 2005-02-25 22:42:19 CET

Okay, committed in r13158.

-Karl

VK Sameer <sameer@collab.net> writes:
> Attached is a patch, including a test case, for issue 2154. make check
> passes.
>
> There are still some unanswered questions which somebody with greater
> familiarity with mod_dav_svn may be able to answer. Or I'll re-visit
> this once I've looked into a few more mod_dav issues. The question is
> why the goto cleanup: blows away the 500 status and picks up the default
> 200 status. I also don't see why a 0 is being returned in the http body.
>
> Also, svn_path_local_style in svn_repos_get_file_revs doesn't seem to
> convert "/A" to "A".
>
> Thanks to a bunch of people, Karl, Madan, and Ben, for their help with
> questions and testing.
>
> Regards
> Sameer
>
> Resolve issue 2154 - svn blame on a directory. Over DAV, this
> fails with an "invalid XML" error message. This patch fixes that.
>
> * subversion/tests/clients/cmdline/blame_tests.py
> (blame_directory): Add new test to blame a directory
> test_list: Added blame_directory test
>
> * subversion/mod_dav_svn/file_revs.c
> (dav_svn__file_revs_report): Change to return immediately without
> cleanup if svn_repos_get_file_revs() returns an error.
>
> * subversion/libsvn_repos/rev_hunt.c
> (svn_repos_get_file_revs): Add path when generating error message
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 25 23:02:11 2005

This is an archived mail posted to the Subversion Dev mailing list.