Re: [PATCH] issue 2154 - svn blame on a directory over DAV does not return gracefully

On Mon, 2005-02-28 at 03:09, Peter N. Lundblad wrote:
>
> FYI, this code was shamelessly stolen (guess by whome:-) from another
> report implementation. I think this bug is present in several places (the
> log code, get_locations), which will lead to ugly errors if some of the
> underlying repos functions fail for some reason. It would be great if you
> fixed those in the same way!

Adding the fix is not a problem, but checking this out showed
inconsistencies in the if expression used at the 'cleanup:' label.
update.c has this:
if ((!derr) && ap_fflush ...)

while file_revs.c, version.c, and log.c have this:

if ((ap_fflush(...) && (!derr))

Checking for !derr first would let 'goto cleanup:' be retained in
file_revs.c, but I don't know if that is a reasonable solution in all
cases. version.c doesn't use the goto idiom, so it doesn't seem to need
this fix. Comments?

Regards
Sameer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 28 05:17:01 2005