[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 2154 - svn blame on a directory over DAV does not return gracefully

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-02-27 22:39:38 CET

On Sat, 26 Feb 2005, VK Sameer wrote:

> On Fri, 2005-02-25 at 21:28, Justin Erenkrantz wrote:
> > --On Friday, February 25, 2005 3:11 PM +0530 VK Sameer <sameer@collab.net>
> > wrote:
> >
> > > The question is why the goto cleanup: blows away the 500 status and picks up the default
> > > 200 status. I also don't see why a 0 is being returned in the http body.
> >
> > No, it's that the cleanup branch calls ap_fflush. flush will tell httpd to
> > write the HTTP headers out and that includes whatever r->status is at that
> > particular time. When we call convert_err, we don't immediately set r->status
> > right then - so r->status remains 0.
>
> Ah, I see.
>
> > Hence, HTTP status 200 is returned.
> >
> > So, your patch is fine as we don't want to call flush. -- justin
>
> OK, thanks for the explanation.

FYI, this code was shamelessly stolen (guess by whome:-) from another
report implementation. I think this bug is present in several places (the
log code, get_locations), which will lead to ugly errors if some of the
underlying repos functions fail for some reason. It would be great if you
fixed those in the same way!

(BTW, thanks for debuggin the get_file_revs rpbolem!)

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 27 22:38:39 2005

This is an archived mail posted to the Subversion Dev mailing list.