[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_xml_is_xml_safe() ... is not so safe?

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-02-18 18:11:45 CET

On Feb 18, 2005, at 10:56 AM, Ben Collins-Sussman wrote:

>
> kfogel and I are persuaded. The final strategy will be:
>
> 1. svn_client_lock() will throw error if it sees a non-xml-safe lock
> comment.
> 2. svn_fs_lock() will do the same.
> 3. svn_ra_dav__lock() will (obviously) xml-escape the lock comment
> before sending.
>
> But... a different problem has come up. See my next mail.
>

I thought that the function svn_xml_is_xml_safe() was our magic ticket,
but upon looking at its implementation, it seems to be overly
restrictive. Look at the bitmask it uses: it won't allow valid UTF8
through!

This is a pretty old function... are there latent bugs lying around?

I suspect we need a new function that allows xml-safe UTF8, and
disallows non-xml-safe UTF8.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 18 18:18:31 2005

This is an archived mail posted to the Subversion Dev mailing list.