[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_xml_is_xml_safe() ... is not so safe?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-02-18 18:54:10 CET

Ben Collins-Sussman wrote:
> I thought that the function svn_xml_is_xml_safe() was our magic ticket,
> but upon looking at its implementation, it seems to be overly
> restrictive. Look at the bitmask it uses: it won't allow valid UTF8
> through!
> This is a pretty old function... are there latent bugs lying around?
> I suspect we need a new function that allows xml-safe UTF8, and
> disallows non-xml-safe UTF8.

This has bothered me for a while. I hope we can just improve its
implementation rather than add another function, but we need to review our uses
of it to be sure, and I haven't done that.

I also haven't investigated what the exact implementation ought to be. (One or
two sub-ranges of UTF are not allowed.)

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 18 18:56:49 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.