[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: safe HTTP transport of lock comments

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-02-18 17:56:33 CET

On Feb 18, 2005, at 9:35 AM, Peter N. Lundblad wrote:
>>
>> Yes, but we should still lossily escape them as they go to the client.
>> People do odd things to their databases sometimes, and don't always go
>> through our APIs. (Yes, I know that technically that's illegal, and
>> not our fault, and all that. But there's no reason for Subversion to
>
> I see this as database corruption. I think a server error is
> appropriate
> in that case.
>
>

kfogel and I are persuaded. The final strategy will be:

   1. svn_client_lock() will throw error if it sees a non-xml-safe lock
comment.
   2. svn_fs_lock() will do the same.
   3. svn_ra_dav__lock() will (obviously) xml-escape the lock comment
before sending.

But... a different problem has come up. See my next mail.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 18 18:04:19 2005

This is an archived mail posted to the Subversion Dev mailing list.