Re: [PATCH] Ruby SWIG-based bindings

Hi,

In <41DB5A45.90102@electricjellyfish.net>
  "Re: [PATCH] Ruby SWIG-based bindings" on Tue, 04 Jan 2005 22:08:53 -0500,
  Garrett Rooney <rooneg@electricjellyfish.net> wrote:

> >>>I'm writing Ruby SWIG-based bindings.
> >>> http://pub.cozmixng.org/~kou/diff/svn-add-ruby-20050104.diff
> >
> >>First of all, there seem to be some parts of the diff that change things
> >>that aren't specific to the ruby bindings,
> >
> > Is it swapping %include position for #include position? (See
> > the attachment.)
>
> That was one spot I noticed. Also you're changing the version of swig
> we compare against in swig.m4. Has that been tested with the other
> language bindings?

Really?
I had removed it from the diff showed at the above URL.

# Other diffs
# (http://pub.cozmixng.org/~kou/diff/svn-add-ruby-*.diff
# excluding http://pub.cozmixng.org/~kou/diff/svn-add-ruby-20050104.diff)
# have it. This is for me. I have only swig 1.3.22.

> > The codes generated by %include sometimes need some type
> > declarations. We have to use #include before the codes
> > generated by %include. So, I swapped %include position for
> > #include position.
>
> That seems reasonable. In general though when submitting a patch it's a
> good idea to format your log message in the style used by the rest of
> Subversion, see the "Writing log messages" section in the HACKING file.

Sorry.
I only wanted to explain you why I do. I was going to write
ChangeLog like format messages after you agree this.

> In this case you might have something like:

Thanks for showing me an example.

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org