[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Ruby SWIG-based bindings

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-01-05 04:08:53 CET

Kouhei Sutou wrote:
> Hi,
> In <41DAD46A.7010300@electricjellyfish.net>
> "Re: [PATCH] Ruby SWIG-based bindings" on Tue, 04 Jan 2005 12:37:46 -0500,
> Garrett Rooney <rooneg@electricjellyfish.net> wrote:
>>>I'm writing Ruby SWIG-based bindings.
>>> http://pub.cozmixng.org/~kou/diff/svn-add-ruby-20050104.diff
>>First of all, there seem to be some parts of the diff that change things
>>that aren't specific to the ruby bindings,
> Is it swapping %include position for #include position? (See
> the attachment.)

That was one spot I noticed. Also you're changing the version of swig
we compare against in swig.m4. Has that been tested with the other
language bindings?

>> and the whole thing really
>>needs a log message indicating what it's doing so that it can be more
>>easily reviewed.
> It is for SWIG-Ruby.
> The codes generated by %include sometimes need some type
> declarations. We have to use #include before the codes
> generated by %include. So, I swapped %include position for
> #include position.

That seems reasonable. In general though when submitting a patch it's a
good idea to format your log message in the style used by the rest of
Subversion, see the "Writing log messages" section in the HACKING file.
  In this case you might have something like:

The code generated by swig when you use %include sometimes needs type
declarations from Subversion header files. To account for this swap the
order of #include and %include.

* subversion/bindings/swig/svn_ra.i: swap order of %include and #include

* subversion/bindings/swig/core.i: ditto.

(and then similar things for the rest of the files modified)

Specific comments about what is being modified in each file makes it
much easier for developers to review a change, either before committing
it or after someone else commits it.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 5 04:09:14 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.