Re: Dumpstream version parsing API warts

On Fri, 2004-11-26 at 17:50, Max Bowsher wrote:
> In 1.1.x, because of dump --deltas, we added svn_repos_parse_dumpstream2 and
> we *CHANGED* the value of SVN_REPOS_DUMPFILE_FORMAT_VERSION to 3.
>
> This was a bad thing to, as we broke code which expected to use
> SVN_REPOS_DUMPFILE_FORMAT_VERSION to produce a dumpstream parseable by
> svn_repos_parse_dumpstream - like our own svndumpfilter!
>
> I therefore propose to *remove* SVN_REPOS_DUMPFILE_FORMAT_VERSION from the
> public API for 1.2

It might be better to make svn_repos_parse_dumpstream work on version 3
dumps as long as they don't use deltas. (It would blow out with an
error as soon as it saw a delta.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 27 07:11:01 2004