[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Dumpstream version parsing API warts

From: Max Bowsher <maxb_at_ukf.net>
Date: 2004-11-27 12:16:31 CET

Greg Hudson wrote:
> On Fri, 2004-11-26 at 17:50, Max Bowsher wrote:
>> In 1.1.x, because of dump --deltas, we added svn_repos_parse_dumpstream2
>> and
>> we *CHANGED* the value of SVN_REPOS_DUMPFILE_FORMAT_VERSION to 3.
>>
>> This was a bad thing to, as we broke code which expected to use
>> SVN_REPOS_DUMPFILE_FORMAT_VERSION to produce a dumpstream parseable by
>> svn_repos_parse_dumpstream - like our own svndumpfilter!
>>
>> I therefore propose to *remove* SVN_REPOS_DUMPFILE_FORMAT_VERSION from
>> the
>> public API for 1.2
>
> It might be better to make svn_repos_parse_dumpstream work on version 3
> dumps as long as they don't use deltas. (It would blow out with an
> error as soon as it saw a delta.)

I think it is better that it errors immediately, rather than potentially
after spent a non-trivial time processing data.

Any thoughts on my proposal to remove the _FORMAT_VERSION define, on the
grounds that it has non non-buggy use?

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 27 12:18:22 2004

This is an archived mail posted to the Subversion Dev mailing list.