[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12013 - in branches/locking/subversion/libsvn_fs_base: . bdb

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-11-27 06:30:53 CET

sussman@tigris.org wrote:

>- if (kind == svn_node_dir)
>+ if ((kind == svn_node_dir)
>+ && (strcmp (path, "/") != 0))
> path = apr_pstrcat (trail->pool, path, "/", NULL);
>
>
You have 4 instances of this very same code in this patch alone. D'you
think it would be time for a bit of refactoring?

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 27 06:31:33 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.