[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12013 - in branches/locking/subversion/libsvn_fs_base: . bdb

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-11-27 15:39:56 CET

On Nov 26, 2004, at 11:30 PM, Branko Čibej wrote:

> sussman@tigris.org wrote:
>
>> - if (kind == svn_node_dir)
>> + if ((kind == svn_node_dir)
>> + && (strcmp (path, "/") != 0))
>> path = apr_pstrcat (trail->pool, path, "/", NULL);
>>
> You have 4 instances of this very same code in this patch alone. D'you
> think it would be time for a bit of refactoring?
>

I considered it, but it doesn't seem worth writing a helper function
for 2 lines of code. I mean, I think it would actually decrease the
readability of the code, and I don't expect the code to change in the
future.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 27 15:41:29 2004

This is an archived mail posted to the Subversion Dev mailing list.